export Leaflet object, public components and toLatLng macro

[buschtoens]

Accessing the Leaflet object (L) is currently only possible like so:

const L = window.L;

Whereas this PR enables importing Leaflet from the addon package.

import L from 'ember-leaflet';

When #106 lands this obviously would need adaption.

[miguelcobain]

@buschtoens I think the way forward would be to

import L from 'leaflet';

directly. However, es6 imports from npm modules with ember-cli doesn't seem to be very easy at the moment.
I don't mind to export L from ember-leaflet, But I think using the default export might be too much.

A snippet from react-leaflet:

import { Map, Marker, Popup, TileLayer } from 'react-leaflet';

Would you mind changing index.js to export all leaflet layers + L so that we have a similar thing in ember-leaflet? That would be awesome.

[buschtoens]

I've exported all classes listed in the reference.

[miguelcobain]

@buschtoens there was a communication error, I think.
I was asking to export all the ember-leaflet classes, not the leaflet ones. Those can be found in the leaflet package.

[buschtoens]

Sorry. 😅 I'll fix that tomorrow.

…

On Thu, Mar 23, 2017, 20:15 Miguel Andrade ***@***.***> wrote: @buschtoens <https://github.com/buschtoens> there was a communication error, I think. I was asking to export all the *ember-leaflet* classes, not the leaflet ones. Those can be found in the leaflet package. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#141 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAy8TINgEBqwBxcqJoDQNbJGtIB9m6dmks5rosS8gaJpZM4MmYVs> .

[buschtoens]

Just for clarification: Which files do you want exported?

• components
• helpers
• macros
• mixins

And what would be the benefit? Couldn't they be imported like so?

import BaseLayerComponent from 'ember-leaflet/components/base-layer';
import { latLngBounds } from 'ember-leaflet/helpers/lat-lng-bounds';
import toLatLng from 'ember-leaflet/macros/to-lat-lng';
import DraggabilityMixin from 'ember-leaflet/mixins/draggability';

Or is this merely for easier access?

[miguelcobain]

Let's start with public-ish things.

Components:

• CircleLayer

• CircleMarkerLayer

• GeojsonLayer

• ImageLayer

• LeafletMap

• MarkerLayer

• PolygonLayer

• PolylineLayer

• PopupLayer

• TileLayer

• TooltipLayer

• WmsTileLayer

• toLatLng macro

I don't see a need to export helpers here. They're basically useless outside of templates. The user could just use the L.method directly instead.
I don't feel very confident exporting mixins right now. They're something private to share functionality between some layers, just like some components.

And what would be the benefit? Couldn't they be imported like so?
Or is this merely for easier access?

Well, yes, at the moment they would be just for easier access because ember-cli doesn't have a way for addons to have private components.
I think this API has some benefits:

• when ember-cli's module unification RFC gets implemented, we will have such a thing as private components
• this API is more in line with es6 module standards
• at least we have some decision on what to export or not, unlike the import from 'ember-leaflet/components/*' form

We should use es6 reexport shorthand like so:

export { default as CircleLayer } from 'ember-leaflet/components/circle-layer';
export { default as CircleMarkerLayer } from 'ember-leaflet/components/circle-marker-layer';
export { default as GeojsonLayer } from 'ember-leaflet/components/geojson-layer';
// ...

[buschtoens]

Done. 🏁

Changelog has been amended. 📝

[miguelcobain]

I don't feel enough confidence to use the default export yet.
It would make sense for the leaflet package itself, but we may want to use this export for something else later?

[miguelcobain]

geo-json-layer file doesn't exist.

[buschtoens]

• Removed default export
• Fixed GeojsonLayer path

[miguelcobain]

🎉