Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rectangle Component #413

Merged
merged 4 commits into from
Jan 24, 2020
Merged

Rectangle Component #413

merged 4 commits into from
Jan 24, 2020

Conversation

Thatalent
Copy link
Contributor

No description provided.

@Thatalent
Copy link
Contributor Author

...to address #12

@Thatalent
Copy link
Contributor Author

Thatalent commented Jan 5, 2020 •
edited
Loading

@miguelcobain Tried to use bounds as the only required params but due to extending polygonLayer, locations became a redundant field in leafletRequiredOptions. I figure since the api is currently using locations for polygonLayers it would make since to just keep it all the same.
I could make some additional changes to replace locations with bounds since that would follow leaflets documentation better but there would be a few places in your docs that would require that change and I didn't want to get ahead of myself.

@miguelcobain miguelcobain merged commit 507ccb7 into miguelcobain:master Jan 24, 2020
@miguelcobain
Copy link
Owner

This is very good work @Thatalent, thank you!

Will be released shortly.

@miguelcobain miguelcobain mentioned this pull request Jan 24, 2020
Closed
@miguelcobain
Copy link
Owner

Released on 4.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Thatalent @miguelcobain