MT.D usability improvements #177
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
February 22, 2013 14:38
…erridden; * Elements.cs: Make IndexOf public; fix the doc for Insert
| @@ -25,7 +25,7 @@ public class DialogViewController : UITableViewController | |||
| { | |||
| public UITableViewStyle Style = UITableViewStyle.Grouped; | |||
| public event Action<NSIndexPath> OnSelection; | |||
| UISearchBar searchBar; | |||
| protected UISearchBar searchBar; | |||
There was a problem hiding this comment.
if something becomes protected, then it has to have public naming rules, so it would hav eto be "SearchBar"
There was a problem hiding this comment.
I will correct this and resubmit a pull request!
On Wed, Mar 6, 2013 at 12:10 PM, Miguel de Icaza
notifications@github.comwrote:
In MonoTouch.Dialog/DialogViewController.cs:
@@ -25,7 +25,7 @@ public class DialogViewController : UITableViewController
{
public UITableViewStyle Style = UITableViewStyle.Grouped;
public event Action OnSelection;
UISearchBar searchBar;protected UISearchBar searchBar;if something becomes protected, then it has to have public naming rules,
so it would hav eto be "SearchBar"—
Reply to this email directly or view it on GitHubhttps://github.com//pull/177/files#r3269596
.
added 24 commits
March 6, 2013 12:12
…C to check for that interface instead of StyledStringElement
… be created. Allow RadioElement to be overridden.
…Need this so I can hide a popover when the app is put into the background.
…erridden; * Elements.cs: Make IndexOf public; fix the doc for Insert
…C to check for that interface instead of StyledStringElement
… be created. Allow RadioElement to be overridden.
…Need this so I can hide a popover when the app is put into the background.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few improvements to MT.D,
Thank you for the great work! By switching to MT.D, I was able to eliminate a bunch of cruft classes and vastly simplify the code!
Updated to comply with public naming rules.