Fixes issue where Callable macro expansion would not register method correctly #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PadraigK
changed the title
PadraigK
commented
Sep 29, 2023
| var goodName: String = "Supertop" | ||
|
|
||
| func _mproxy_set_goodName (args: [Variant]) -> Variant? { | ||
| /* goodName = String(args [0])!*/ |
There was a problem hiding this comment.
Not changed in this PR, but surprising that this expands to a /* */ block — is this a bug @migueldeicaza?
There was a problem hiding this comment.
Yes, this was some leftover debugging code, I will remove it.
|
Thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The macro was expanding to register a func with the literal name "funcName" instead of the contents of the variable
funcName.Also adds tests for the Godot, Export and Callable macros.