Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change enum prefix detection strategy #145

Merged
merged 20 commits into from
Oct 6, 2023
Merged

Change enum prefix detection strategy #145

merged 20 commits into from
Oct 6, 2023

Commits on Oct 1, 2023

  1. Change enum prefix detection strategy 

    It will now find the common prefix among all case names instead of relying on the enum definition name.
    @PadraigK
    PadraigK committed Oct 1, 2023
    Configuration menu
    Copy the full SHA
    db115a8 View commit details
    Browse the repository at this point in the history

  2. Adjust linker settings since dynamic_lookup is macOS-specific

    @tishin
    tishin committed Oct 1, 2023
    Configuration menu
    Copy the full SHA
    2680f3f View commit details
    Browse the repository at this point in the history

  3. Adopt new enums everywhere

    @PadraigK
    PadraigK committed Oct 1, 2023
    Configuration menu
    Copy the full SHA
    eb7212a View commit details
    Browse the repository at this point in the history

  4. Get tests passing

    @PadraigK
    PadraigK committed Oct 1, 2023
    Configuration menu
    Copy the full SHA
    71e43de View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2023

  1. Merge pull request migueldeicaza#147 from tishin/macos-linker-settings 

    Adjust linker settings since dynamic_lookup is macOS-specific
    @migueldeicaza
    migueldeicaza authored Oct 2, 2023
    Configuration menu
    Copy the full SHA
    c416b4e View commit details
    Browse the repository at this point in the history

  2. Better approach to invalid names. 

    Instead of prefixing with "_" when the name would be invalid, lets keep the original prefix.
    @PadraigK
    PadraigK committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    95e8661 View commit details
    Browse the repository at this point in the history

  3. Special case MethodFlags so we get a nicer enum 

    Fixes migueldeicaza#23
    @PadraigK
    PadraigK committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    ad629cb View commit details
    Browse the repository at this point in the history

  4. Fix tabs vs spaces

    @PadraigK
    PadraigK committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    e221090 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2023

  1. Fix the tests

    @migueldeicaza
    migueldeicaza committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    ad8aa38 View commit details
    Browse the repository at this point in the history

  2. Another side effect of the calling convention changes in Godot 4.1: o… 

    …n virtual calls, we need to dereference the value passed
    @migueldeicaza
    migueldeicaza committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    743ad1a View commit details
    Browse the repository at this point in the history

  3. Adjust linker settings since dynamic_lookup is macOS-specific

    @tishin @PadraigK
    tishin authored and PadraigK committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    891eafe View commit details
    Browse the repository at this point in the history

  4. Change enum prefix detection strategy 

    It will now find the common prefix among all case names instead of relying on the enum definition name.
    @PadraigK
    PadraigK committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    39f45dd View commit details
    Browse the repository at this point in the history

  5. Adopt new enums everywhere

    @PadraigK
    PadraigK committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    353ff18 View commit details
    Browse the repository at this point in the history

  6. Get tests passing

    @PadraigK
    PadraigK committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    3eda8a5 View commit details
    Browse the repository at this point in the history

  7. Better approach to invalid names. 

    Instead of prefixing with "_" when the name would be invalid, lets keep the original prefix.
    @PadraigK
    PadraigK committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    9dc6104 View commit details
    Browse the repository at this point in the history

  8. Special case MethodFlags so we get a nicer enum 

    Fixes migueldeicaza#23
    @PadraigK
    PadraigK committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    e663459 View commit details
    Browse the repository at this point in the history

  9. Fix tabs vs spaces

    @PadraigK
    PadraigK committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    5d672db View commit details
    Browse the repository at this point in the history

  10. Merge branch 'main' of github.com:PadraigK/SwiftGodot into main-padraig

    @PadraigK
    PadraigK committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    94698d3 View commit details
    Browse the repository at this point in the history

  11. Apply suggestions from code review 

    Co-authored-by: Marquis Kurt <software@marquiskurt.net>
    @PadraigK @alicerunsonfedora
    PadraigK and alicerunsonfedora authored Oct 5, 2023
    Configuration menu
    Copy the full SHA
    b04b079 View commit details
    Browse the repository at this point in the history

  12. fix dropped end brace

    @PadraigK
    PadraigK committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    dbceb23 View commit details
    Browse the repository at this point in the history