Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eradicate optional Variant #567

Conversation

elijah-semyonov
Copy link
Contributor

@elijah-semyonov elijah-semyonov commented Oct 5, 2024

Change API to reflect nullability as an intrinsic part of Variant semantics to avoid awkward states like Variant? containing .some(Variant) containing Godot Nil.

@migueldeicaza
Copy link
Owner

You have some enthusiastic comments on Slack during your code review that lead to this, would love to know more about those.

generally, being a breaking change I am a bit concerned about this, but also losing the language support. An alternative is going the other way, but as I mentioned on slack, that could lead to an impedance mismatch.

so I think it would be good to explore the pros and cons in depth before crossing either bridge

@elijah-semyonov
Copy link
Contributor Author

elijah-semyonov commented Oct 5, 2024

I'll cook the opposite approach and try to amalgamate Godot Nil into Swift nil.

@elijah-semyonov elijah-semyonov deleted the eradicate-optional-variant branch October 9, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants