Fix some warnings #723
Merged
Fix some warnings #723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was looking through some of the warnings and some of them are easily fixable
cosmicburp
commented
Jul 12, 2025
| @@ -61,7 +61,7 @@ public struct SignalWithArguments<each T: _GodotBridgeable> { | |||
| @discardableResult | |||
| public func connect(flags: Object.ConnectFlags = [], _ callback: @escaping (_ t: repeat each T) -> Void) -> Callable { | |||
| let callable = Callable(callback) | |||
| let error = target?.connect(signal: signalName, callable: callable, flags: UInt32(flags.rawValue)) | |||
| _ = target?.connect(signal: signalName, callable: callable, flags: UInt32(flags.rawValue)) | |||
There was a problem hiding this comment.
I'd like to actually make this a throwing function but that would break everyone. Not sure what kind of errors we could expect from this anyhow.
cosmicburp
commented
Jul 12, 2025
| @@ -186,7 +186,7 @@ public struct TypedArray<Element: _GodotContainerTypingParameter>: CustomDebugSt | |||
| hasher.combine(hash()) | |||
| } | |||
|
|
|||
| public static func ==(lhs: Self, rhs: Self) { | |||
| public static func == (lhs: Self, rhs: Self) -> Bool { | |||
There was a problem hiding this comment.
This seems like a genuine error. As in the equatable wasn't implemented at all. Notably also now that I look at it the hash() implementation isn't mirroring the equatable implementation which might cause issues too. They should both use hash or both use array. This might not be a problem not I'd have to see how hash is generated
|
Thank you for your contribution! I am a bit unsure about one of the changes on the private, but we will test it live :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking through some of the warnings and some of them are easily fixable