-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Bump min Android SDK version #1530
Conversation
What's the progress on this ? This pr will solve a bug im facing !! :) |
I need to get a hold of a reviewer to get this approved first. |
8bffac2
to
7160fe2
Compare
cc @philenius Not sure if you could rubber stamp this one? Miguel seems to be busy at the moment. |
As a temp fix, i updated the version number from my .pub-cache folder and it lets me build the project; the fix seems to work :) I would love to just have it patched in the lib, so my team can use it without worrying to much; :) |
@Mik1337 I would advise against that, as a You could instead use a git dependency on this PR branch |
yeah fair, that makes more sense; |
I am facing same issue on IOS, Android, MACOS..... For web it works... |
I have tested this pr for IOS Build and it is working fine. issue #1531 is resolved |
I can confirm that (with the changes of this pull request) the Linux implementation still works. Let me check on Windows and macOS. |
@philenius this is actually a breaking change it should not have been released by just bumping patch version to 6 e.g. 8.0.6, rather with major version e.g. 9.0.0. It's going to break many apps using dependabot. This package should follow Semantic Versioning https://semver.org like other packages and Flutter |
@absar, thanks for letting me know. I'm aware of semver but I have no clue of Android. @navaronbracke, please keep this in mind for next time when changing the Android SDK! |
I am also aware of semver, but I was following the Flutter policy of only supporting current stable + 2 major Flutter releases before that. And SDK 19 (which was the previous minimum) has been unsupported since April 2023 by Google Play. So while this might have impacted semver, it probably isn't such a big deal in the first place. |
This PR updates the minimum Android SDK version to 21, to align with the current minimum on Flutter 3.22.
It also updates the compile & target SDK versions to 34 and fixes a versioning issue for win32.
In a follow-up PR, I will also migrate the plugin to Gradle 8.
Fix was tested by compiling and running the example app on an Android 14 device.
Fixes #1522
Fixes #1528
Fixes #1531