Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Bump min Android SDK version #1530

Merged
merged 4 commits into from
Jul 1, 2024

Conversation

navaronbracke
Copy link
Collaborator

@navaronbracke navaronbracke commented Jun 10, 2024

This PR updates the minimum Android SDK version to 21, to align with the current minimum on Flutter 3.22.

It also updates the compile & target SDK versions to 34 and fixes a versioning issue for win32.

In a follow-up PR, I will also migrate the plugin to Gradle 8.

Fix was tested by compiling and running the example app on an Android 14 device.

Fixes #1522
Fixes #1528
Fixes #1531

@Mik1337
Copy link

Mik1337 commented Jun 15, 2024

What's the progress on this ? This pr will solve a bug im facing !! :)

@navaronbracke
Copy link
Collaborator Author

I need to get a hold of a reviewer to get this approved first.

@navaronbracke
Copy link
Collaborator Author

cc @philenius Not sure if you could rubber stamp this one? Miguel seems to be busy at the moment.

@Mik1337
Copy link

Mik1337 commented Jun 15, 2024

As a temp fix, i updated the version number from my .pub-cache folder and it lets me build the project; the fix seems to work :)

I would love to just have it patched in the lib, so my team can use it without worrying to much; :)

@navaronbracke
Copy link
Collaborator Author

@Mik1337 I would advise against that, as a flutter clean will erase that change in your pub cache.

You could instead use a git dependency on this PR branch

@Mik1337
Copy link

Mik1337 commented Jun 15, 2024

yeah fair, that makes more sense;

@dkliss
Copy link

dkliss commented Jun 26, 2024

I am facing same issue on IOS, Android, MACOS..... For web it works...

@Shahidbangash
Copy link

I have tested this pr for IOS Build and it is working fine. issue #1531 is resolved

@philenius
Copy link
Collaborator

philenius commented Jul 1, 2024

I can confirm that (with the changes of this pull request) the Linux implementation still works. Let me check on Windows and macOS.
Update: It works on Windows 11, too. Don't have time for macOS and your changes should not affect the macOS implementation. Good work, thank you @navaronbracke 🚀

@philenius philenius self-assigned this Jul 1, 2024
@philenius philenius self-requested a review July 1, 2024 17:40
CHANGELOG.md Outdated Show resolved Hide resolved
@philenius philenius merged commit 5ee4805 into miguelpruivo:master Jul 1, 2024
3 checks passed
@absar
Copy link

absar commented Jul 9, 2024

@philenius this is actually a breaking change it should not have been released by just bumping patch version to 6 e.g. 8.0.6, rather with major version e.g. 9.0.0. It's going to break many apps using dependabot. This package should follow Semantic Versioning https://semver.org like other packages and Flutter

@navaronbracke navaronbracke deleted the min_sdk_version branch July 10, 2024 05:53
@philenius
Copy link
Collaborator

@absar, thanks for letting me know. I'm aware of semver but I have no clue of Android. @navaronbracke, please keep this in mind for next time when changing the Android SDK!

@navaronbracke
Copy link
Collaborator Author

navaronbracke commented Jul 10, 2024

I am also aware of semver, but I was following the Flutter policy of only supporting current stable + 2 major Flutter releases before that. And SDK 19 (which was the previous minimum) has been unsupported since April 2023 by Google Play. So while this might have impacted semver, it probably isn't such a big deal in the first place.

See also https://android-developers.googleblog.com/2023/07/google-play-services-discontinuing-updates-for-kitkat.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants