Fix web example on Flutter 3.22 #1578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -16,16 +16,8 @@ | |||
|
|
|||
| <title>example</title> | |||
| <link rel="manifest" href="manifest.json"> | |||
| <script src="flutter.js"></script> | |||
There was a problem hiding this comment.
|
The undefined module error is tracked for a cherry pick to stable, see flutter/flutter#152844 |
navaronbracke
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the example for the web, that now needs a different method of bootstrapping in Flutter 3.22
I had forgotten to include this commit in my last PR, after testing the web example.
We still hit the CanvasKit undefined module error when running the example a second time, but this was reported upstream in flutter/flutter.