Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for TOML configurations #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

matthewspear
Copy link
Collaborator

@matthewspear matthewspear commented Feb 24, 2020

Feature follows on from issue #32. Instead of re-writing the parameter components (which are tightly coupled all over slambench) I opted to go for a simpler approach. I have written a TOML converter that takes in a TOML configuration file and converts it into parameters.

The pros of this approach are that it is simpler (~300 loc), allows support for both TOML, command-line arguments or a combination of both! The cons are that it requires a mapping between TOML argument and command line (e.g frame_rate: 30 in TOML would be -fps 30 as a command line parameter).

For the parameters I have added support for ORBSlam2, KFusion, ReFusion and Efusion (although haven't been able to test them all). I've added TOML support to both benchmark_loader and pangolin_loader using -t or --toml and the file path. I have provided an example that loads all the default parameters for ORBSLAM2 with TUM.

Let me know if you have any questions / required changes!

Changelog:

  • Added cpptoml dependency to handle TOML file parsing
  • Implemented a converter to take a TOML file and output the command line arguments in place
  • Added defaults example config file for ORBSLAM2 with TUM dataset

- Added cpptoml dependency to handle TOML file parsing
- Implemented a converter to take a TOML file and output the command line arguments in place
- Added defaults example config file for ORBSLAM2 with TUM dataset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant