Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature follows on from issue #32. Instead of re-writing the parameter components (which are tightly coupled all over slambench) I opted to go for a simpler approach. I have written a TOML converter that takes in a TOML configuration file and converts it into parameters.
The pros of this approach are that it is simpler (~300 loc), allows support for both TOML, command-line arguments or a combination of both! The cons are that it requires a mapping between TOML argument and command line (e.g
frame_rate: 30
in TOML would be-fps 30
as a command line parameter).For the parameters I have added support for ORBSlam2, KFusion, ReFusion and Efusion (although haven't been able to test them all). I've added TOML support to both
benchmark_loader
andpangolin_loader
using-t
or--toml
and the file path. I have provided an example that loads all the default parameters for ORBSLAM2 with TUM.Let me know if you have any questions / required changes!
Changelog: