Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict to Cabal < 3.12 #962

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Conversation

toku-sa-n
Copy link
Collaborator

@toku-sa-n toku-sa-n commented Sep 20, 2024

Description of the PR

To fix a build error.

Cabal 3.12 uses SymbolicPathX, but it is not exported from the library, and thus, we cannot use it.

Probably we should set version bounds to all dependencies, and update the bounds when needed, e.g., new functions are required, to keep up with the new Stackage LTS, etc.

Checklist

Cabal 3.12 uses `SymbolicPathX`, but it is not exported from the library, and thus, we cannot use it.
@toku-sa-n toku-sa-n marked this pull request as ready for review September 20, 2024 23:24
@toku-sa-n toku-sa-n enabled auto-merge (squash) September 23, 2024 01:54
@toku-sa-n toku-sa-n changed the title Restrict Cabal < 3.12 Restrict to Cabal < 3.12 Sep 24, 2024
Copy link
Owner

@mihaimaruseac mihaimaruseac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we should probably have upper bounds for everything, but let's do them on demand, as needed.

@toku-sa-n toku-sa-n merged commit 8053387 into mihaimaruseac:master Sep 26, 2024
23 checks passed
@toku-sa-n toku-sa-n deleted the fix-build branch September 26, 2024 11:23
@toku-sa-n toku-sa-n mentioned this pull request Nov 27, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants