-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update deprecated keycodes #19
Conversation
Hello Antoine, Indeed. What is really needed is an update to the latest QMK version for the whole package, not just bits and pieces. I will have to look into it as soon as possible. Mihai |
Would you have a rough list of things that need to be updated? I can craft a more complete patch if it helps. |
Would updating to the latest QMK break existing functionality? One thing I've missed adding to the README is the QMK version that mugur requires. With this PR it should be 0.22. But, again, we should make sure that all other existing features still work. |
Ok so, assuming current is
This is quite the mouthful so I'm going to curate it to only keep the things that seem relevant to EDIT: Removed |
On closer inspection, it seems the keycode changes are not referenced in the tags. Here is the pull request that changes them: |
That went somewhat quicker than I expected. I reviewed the aforementioned list and didn't find anything that seems to affect Feel free to merge or close the PR, whichever you prefer, I have included my own version in my |
That looks quite reasonable to me.
Thanks for the great effort! |
Using
mugur
on debian bookworm with the latest QMK firmware package, those keycodes seem to be outdated. I took the values from https://docs.qmk.fm/#/keycodes and they seem to compile just fine.