New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete link should probably be a button #27

Closed

mihkelal opened this issue Aug 26, 2021 · 0 comments · Fixed by #45

Assignees

Owner

mihkelal commented Aug 26, 2021 •

edited

Loading

For accessibility reasons, we should continue to promote buttons rather than method links, but this makes Hotwire much easier to fit into existing applications that were built to Rails UJS standards. (hotwired/turbo#277)

https://api.rubyonrails.org/classes/ActionView/Helpers/UrlHelper.html#method-i-button_to
https://api.rubyonrails.org/classes/ActionView/Helpers/UrlHelper.html#method-i-link_to

Plus it will remove the need for JS in system specs.

mihkelal self-assigned this

mihkelal linked a pull request

that will close this issue

Move links to top, switch complete link to button #45

Merged

mihkelal mentioned this issue

Move links to top, switch complete link to button #45

Merged

mihkelal closed this as completed in #45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment