Turn links with methods into form submissions #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelolx
approved these changes
Jun 4, 2021
|
This seems to only work within a turbo-frame, is it expected behaviour ? I am not sure as it is advertised to be a replacement for data-method links |
|
@Intrepidd Ah yes, need to expand it to all cases. If you want to take a swing at a PR for that 👍 |
ghiculescu
added a commit
to ghiculescu/turbo-site
that referenced
this pull request
Oct 11, 2021
Adds docs for hotwired/turbo#277 + hotwired/turbo#299
seanpdoyle
added a commit
to seanpdoyle/turbo-rails
that referenced
this pull request
Oct 12, 2021
As an alternative to building support for Rails' Unobtrusive JavaScript into `@hotwired/turbo` itself, instead publish a `@hotwired/turbo-rails/ujs` file to re-use the existing `@rails/ujs` hooks, and bridge the gaps between new `turbo:`-prefixed and `ajax:`-prefixed events. This is a re-imagining of [hotwired/turbo#40][] and ([hotwired/turbo#384][]). If deemed viable, this work would yield some follow up tasks: * drop support for `[data-turbo-method]` ([hotwired/turbo#277][]) * drop support for `[data-confirm]` ([hotwired/turbo#379][]) [hotwired/turbo#40]: hotwired/turbo#40 [hotwired/turbo#277]: hotwired/turbo#277 [hotwired/turbo#379]: hotwired/turbo#379 [hotwired/turbo#384]:hotwired/turbo#384
seanpdoyle
added a commit
to seanpdoyle/turbo-rails
that referenced
this pull request
Oct 12, 2021
As an alternative to building support for Rails' Unobtrusive JavaScript into `@hotwired/turbo` itself, instead publish a `@hotwired/turbo-rails/ujs` file to re-use the existing `@rails/ujs` hooks, and bridge the gaps between new `turbo:`-prefixed and `ajax:`-prefixed events. This is a re-imagining of [hotwired/turbo#40][] and ([hotwired/turbo#384][]). If deemed viable, this work would yield some follow up tasks: * drop support for `[data-turbo-method]` ([hotwired/turbo#277][]) * drop support for `[data-confirm]` ([hotwired/turbo#379][]) [hotwired/turbo#40]: hotwired/turbo#40 [hotwired/turbo#277]: hotwired/turbo#277 [hotwired/turbo#379]: hotwired/turbo#379 [hotwired/turbo#384]:hotwired/turbo#384
seanpdoyle
added a commit
to seanpdoyle/turbo-rails
that referenced
this pull request
Oct 12, 2021
As an alternative to building support for Rails' Unobtrusive JavaScript into `@hotwired/turbo` itself, instead publish a `@hotwired/turbo-rails/ujs` file to re-use the existing `@rails/ujs` hooks, and bridge the gaps between new `turbo:`-prefixed and `ajax:`-prefixed events. This is a re-imagining of [hotwired/turbo#40][] and ([hotwired/turbo#384][]). If deemed viable, this work would yield some follow up tasks: * drop support for `[data-turbo-method]` ([hotwired/turbo#277][]) * drop support for `[data-confirm]` ([hotwired/turbo#379][]) [hotwired/turbo#40]: hotwired/turbo#40 [hotwired/turbo#277]: hotwired/turbo#277 [hotwired/turbo#379]: hotwired/turbo#379 [hotwired/turbo#384]:hotwired/turbo#384
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails UJS offered a path to turn links into form submissions via the data-method attribute. This PR recreates that capability under data-turbo-method (but also with data-method for compatibility with existing apps built to Rails UJS).
The link is turned into a form that's added next to the link in the dom, such that all the frame scopes still apply, and corresponding behavior is triggered.
For accessibility reasons, we should continue to promote buttons rather than method links, but this makes Hotwire much easier to fit into existing applications that were built to Rails UJS standards.