Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using % in a default category crashes screen: More > Settings > Library #1029

Closed
6 tasks done
vetleledaal opened this issue Jul 18, 2024 · 0 comments · Fixed by #1030
Closed
6 tasks done

Using % in a default category crashes screen: More > Settings > Library #1029

vetleledaal opened this issue Jul 18, 2024 · 0 comments · Fixed by #1030
Labels
Bug Something isn't working
Milestone
v0.17.0

Comments

@vetleledaal
Copy link
Contributor

Steps to reproduce

  1. Open the app
  2. Tap More
  3. Tap Settings
  4. Tap Library
  5. Tap 'Edit categories'
  6. Tap '+ Add'
  7. Input test%
  8. Tap Add
  9. Navigate back
  10. Tap 'Default category'
  11. Tap 'test%'

Expected behavior

test% is shown as the default category.

Actual behavior

App crashes on screen: More > Settings > Library.

Crash logs

App version: 0.16.5-6776 (standard, f63e95091, 7, 2024-07-13T21:19:14Z)
Android version: 14 (SDK 34; build 2024071600)
Device brand: google
Device manufacturer: Google
Device name: cheetah (cheetah)
Device model: Pixel 7 Pro
WebView: Vanadium System WebView 126.0.6478.122.3

java.lang.Throwable: java.util.UnknownFormatConversionException: Conversion = 'End of String'
	at java.util.Formatter$FormatSpecifierParser.peek(Formatter.java:2821)
	at java.util.Formatter$FormatSpecifierParser.<init>(Formatter.java:2782)
	at java.util.Formatter.parse(Formatter.java:2737)
	at java.util.Formatter.format(Formatter.java:2686)
	at java.util.Formatter.format(Formatter.java:2640)
	at java.lang.String.format(String.java:4027)
	at eu.kanade.presentation.more.settings.Preference$PreferenceItem$ListPreference$1.invoke(Unknown Source:37)
	at eu.kanade.presentation.more.settings.PreferenceItemKt$PreferenceItem$1.invoke(Unknown Source:233)
	at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(SourceFile:7)
	at androidx.compose.runtime.AnchoredGroupPath.CompositionLocalProvider(SourceFile:77)
	at eu.kanade.presentation.more.settings.PreferenceItemKt$StatusWrapper$1.invoke(Unknown Source:30)
	at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(SourceFile:35)
	at androidx.compose.foundation.CanvasKt$Canvas$1.invoke(Unknown Source:595)
	at androidx.compose.runtime.ComposerImpl.recomposeToGroupEnd(Unknown Source:437)
	at androidx.compose.runtime.ComposerImpl.skipToGroupEnd(Unknown Source:28)
	at androidx.compose.animation.CrossfadeKt.AnimatedVisibility(SourceFile:2)
	at eu.kanade.presentation.more.settings.PreferenceItemKt.StatusWrapper(Unknown Source:145)
	at eu.kanade.presentation.more.settings.PreferenceItemKt.PreferenceItem(Unknown Source:101)
	at eu.kanade.presentation.more.settings.PreferenceScreenKt$PreferenceScreen$lambda$4$lambda$3$lambda$2$$inlined$items$default$4.invoke(Unknown Source:82)
	at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(SourceFile:45)
	at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(SourceFile:11)
	at androidx.compose.foundation.layout.BoxKt$Box$2.invoke(Unknown Source:537)
	at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(SourceFile:7)
	at androidx.compose.runtime.ComposerImpl.recomposeToGroupEnd(Unknown Source:437)
	at androidx.compose.runtime.ComposerImpl.skipToGroupEnd(Unknown Source:28)
	at androidx.compose.foundation.lazy.layout.LazyLayoutKt.LazyLayoutPinnableItem(Unknown Source:95)
	at androidx.compose.foundation.lazy.LazyListItemProviderImpl.Item(Unknown Source:103)
	at androidx.compose.foundation.CanvasKt$Canvas$1.invoke(Unknown Source:797)
	at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(SourceFile:7)
	at androidx.compose.runtime.ComposerImpl.recomposeToGroupEnd(Unknown Source:437)
	at androidx.compose.runtime.ComposerImpl.skipToGroupEnd(Unknown Source:28)
	at androidx.compose.foundation.lazy.layout.LazySaveableStateHolder.SaveableStateProvider(Unknown Source:67)
	at androidx.compose.foundation.lazy.layout.LazyLayoutKt.access$SkippableItem-JVlU9Rs(Unknown Source:104)
	at androidx.compose.foundation.lazy.layout.LazyLayoutItemContentFactory$CachedItemContent$createContentLambda$1.invoke(Unknown Source:107)
	at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(SourceFile:7)
	at androidx.compose.runtime.ComposerImpl.recomposeToGroupEnd(Unknown Source:437)
	at androidx.compose.runtime.ComposerImpl.skipCurrentGroup(Unknown Source:136)
	at androidx.compose.runtime.ComposerImpl.doCompose(Unknown Source:244)
	at androidx.compose.runtime.ComposerImpl.recompose$runtime_release(Unknown Source:31)
	at androidx.compose.runtime.CompositionImpl.recompose(Unknown Source:22)
	at androidx.compose.runtime.Recomposer.access$performRecompose(Unknown Source:116)
	at androidx.compose.material3.DatePickerKt$HorizontalMonthsList$1$2$1.invoke(Unknown Source:611)
	at androidx.compose.ui.platform.AndroidUiFrameClock$withFrameNanos$2$callback$1.doFrame(Unknown Source:33)
	at androidx.compose.ui.platform.AndroidUiDispatcher$dispatchCallback$1.doFrame(Unknown Source:47)
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1404)
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1415)
	at android.view.Choreographer.doCallbacks(Choreographer.java:1015)
	at android.view.Choreographer.doFrame(Choreographer.java:941)
	at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1389)
	at android.os.Handler.handleCallback(Handler.java:959)
	at android.os.Handler.dispatchMessage(Handler.java:100)
	at android.os.Looper.loopOnce(Looper.java:232)
	at android.os.Looper.loop(Looper.java:317)
	at android.app.ActivityThread.main(ActivityThread.java:8623)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:580)
	at com.android.internal.os.ExecInit.main(ExecInit.java:50)
	at com.android.internal.os.RuntimeInit.nativeFinishInit(Native Method)
	at com.android.internal.os.RuntimeInit.main(RuntimeInit.java:369)


--------- beginning of main
07-18 16:37:24.726 26418 26418 E app.mihon.debug: Not starting debugger since process cannot load the jdwp agent.
07-18 16:37:24.809 26418 26418 E cutils-trace: Error opening trace file: No such file or directory (2)
07-18 16:37:24.950 26418 26418 E app.mihon.debug: Unable to find pattern file or unable to map it for am
07-18 16:37:25.019 26418 26455 E DynamiteModule: Invalid GmsCore APK, remote loading disabled.
07-18 16:37:25.020 26418 26455 E DynamiteModule: Invalid GmsCore APK, remote loading disabled.
07-18 16:37:25.105 26418 26479 E SQLiteLog: (28) double-quoted string literal: ""
07-18 16:37:25.110 26418 26418 E WebViewLibraryLoader: can't load with relro file; address space not reserved
07-18 16:37:25.421 26418 26498 E SQLiteLog: (284) automatic index on C(manga_id)
07-18 16:37:25.421 26418 26498 E SQLiteLog: (284) automatic index on mangas_categories(manga_id)
07-18 16:37:25.514 26418 26515 E cutils-trace: Error opening trace file: No such file or directory (2)
07-18 16:37:53.376 26418 26418 E ImeBackDispatcher: Ime callback not found. Ignoring unregisterReceivedCallback. callbackId: 32807375
07-18 16:38:04.634 26418 26418 E ImeBackDispatcher: Ime callback not found. Ignoring unregisterReceivedCallback. callbackId: 32807375
--------- beginning of crash
07-18 16:38:08.469 26418 26418 E AndroidRuntime: FATAL EXCEPTION: main
07-18 16:38:08.469 26418 26418 E AndroidRuntime: Process: app.mihon.debug, PID: 26418
07-18 16:38:08.469 26418 26418 E AndroidRuntime: java.util.UnknownFormatConversionException: Conversion = 'End of String'
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at java.util.Formatter$FormatSpecifierParser.peek(Formatter.java:2821)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at java.util.Formatter$FormatSpecifierParser.<init>(Formatter.java:2782)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at java.util.Formatter.parse(Formatter.java:2737)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at java.util.Formatter.format(Formatter.java:2686)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at java.util.Formatter.format(Formatter.java:2640)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at java.lang.String.format(String.java:4027)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at eu.kanade.presentation.more.settings.Preference$PreferenceItem$ListPreference$1.invoke(Unknown Source:37)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at eu.kanade.presentation.more.settings.PreferenceItemKt$PreferenceItem$1.invoke(Unknown Source:233)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(SourceFile:7)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at androidx.compose.runtime.AnchoredGroupPath.CompositionLocalProvider(SourceFile:77)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at eu.kanade.presentation.more.settings.PreferenceItemKt$StatusWrapper$1.invoke(Unknown Source:30)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(SourceFile:35)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at androidx.compose.foundation.CanvasKt$Canvas$1.invoke(Unknown Source:595)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at androidx.compose.runtime.ComposerImpl.recomposeToGroupEnd(Unknown Source:437)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at androidx.compose.runtime.ComposerImpl.skipToGroupEnd(Unknown Source:28)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at androidx.compose.animation.CrossfadeKt.AnimatedVisibility(SourceFile:2)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at eu.kanade.presentation.more.settings.PreferenceItemKt.StatusWrapper(Unknown Source:145)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at eu.kanade.presentation.more.settings.PreferenceItemKt.PreferenceItem(Unknown Source:101)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at eu.kanade.presentation.more.settings.PreferenceScreenKt$PreferenceScreen$lambda$4$lambda$3$lambda$2$$inlined$items$default$4.invoke(Unknown Source:82)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(SourceFile:45)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(SourceFile:11)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at androidx.compose.foundation.layout.BoxKt$Box$2.invoke(Unknown Source:537)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(SourceFile:7)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at androidx.compose.runtime.ComposerImpl.recomposeToGroupEnd(Unknown Source:437)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at androidx.compose.runtime.ComposerImpl.skipToGroupEnd(Unknown Source:28)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at androidx.compose.foundation.lazy.layout.LazyLayoutKt.LazyLayoutPinnableItem(Unknown Source:95)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at androidx.compose.foundation.lazy.LazyListItemProviderImpl.Item(Unknown Source:103)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at androidx.compose.foundation.CanvasKt$Canvas$1.invoke(Unknown Source:797)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(SourceFile:7)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at androidx.compose.runtime.ComposerImpl.recomposeToGroupEnd(Unknown Source:437)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at androidx.compose.runtime.ComposerImpl.skipToGroupEnd(Unknown Source:28)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at androidx.compose.foundation.lazy.layout.LazySaveableStateHolder.SaveableStateProvider(Unknown Source:67)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at androidx.compose.foundation.lazy.layout.LazyLayoutKt.access$SkippableItem-JVlU9Rs(Unknown Source:104)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at androidx.compose.foundation.lazy.layout.LazyLayoutItemContentFactory$CachedItemContent$createContentLambda$1.invoke(Unknown Source:107)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(SourceFile:7)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at androidx.compose.runtime.ComposerImpl.recomposeToGroupEnd(Unknown Source:437)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at androidx.compose.runtime.ComposerImpl.skipCurrentGroup(Unknown Source:136)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at androidx.compose.runtime.ComposerImpl.doCompose(Unknown Source:244)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at androidx.compose.runtime.ComposerImpl.recompose$runtime_release(Unknown Source:31)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at androidx.compose.runtime.CompositionImpl.recompose(Unknown Source:22)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at androidx.compose.runtime.Recomposer.access$performRecompose(Unknown Source:116)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at androidx.compose.material3.DatePickerKt$HorizontalMonthsList$1$2$1.invoke(Unknown Source:611)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at androidx.compose.ui.platform.AndroidUiFrameClock$withFrameNanos$2$callback$1.doFrame(Unknown Source:33)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at androidx.compose.ui.platform.AndroidUiDispatcher$dispatchCallback$1.doFrame(Unknown Source:47)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1404)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1415)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at android.view.Choreographer.doCallbacks(Choreographer.java:1015)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at android.view.Choreographer.doFrame(Choreographer.java:941)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1389)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at android.os.Handler.handleCallback(Handler.java:959)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at android.os.Handler.dispatchMessage(Handler.java:100)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at android.os.Looper.loopOnce(Looper.java:232)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at android.os.Looper.loop(Looper.java:317)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at android.app.ActivityThread.main(ActivityThread.java:8623)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at java.lang.reflect.Method.invoke(Native Method)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:580)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at com.android.internal.os.ExecInit.main(ExecInit.java:50)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at com.android.internal.os.RuntimeInit.nativeFinishInit(Native Method)
07-18 16:38:08.469 26418 26418 E AndroidRuntime: 	at com.android.internal.os.RuntimeInit.main(RuntimeInit.java:369)
07-18 16:38:08.611 26954 26954 E g:error_handler: Not starting debugger since process cannot load the jdwp agent.
07-18 16:38:08.682 26954 26954 E cutils-trace: Error opening trace file: No such file or directory (2)
07-18 16:38:08.823 26954 26954 E app.mihon.debug:error_handler: Unable to find pattern file or unable to map it for am
07-18 16:38:08.921 26954 26984 E SQLiteLog: (283) recovered 1 frames from WAL file /data/data/app.mihon.debug/databases/tachiyomi.db-wal
07-18 16:38:08.932 26954 26954 E WebViewLibraryLoader: can't load with relro file; address space not reserved
07-18 16:38:09.164 26954 27000 E cutils-trace: Error opening trace file: No such file or directory (2)
07-18 16:38:11.102 27087 27087 E app.mihon.debug: Not starting debugger since process cannot load the jdwp agent.
07-18 16:38:11.193 27087 27087 E cutils-trace: Error opening trace file: No such file or directory (2)
07-18 16:38:11.362 27087 27087 E app.mihon.debug: Unable to find pattern file or unable to map it for am
07-18 16:38:11.450 27087 27118 E DynamiteModule: Invalid GmsCore APK, remote loading disabled.
07-18 16:38:11.450 27087 27118 E DynamiteModule: Invalid GmsCore APK, remote loading disabled.
07-18 16:38:11.533 27087 27087 E WebViewLibraryLoader: can't load with relro file; address space not reserved
07-18 16:38:11.533 27087 27133 E SQLiteLog: (5) statement aborts at 2: [PRAGMA journal_mode=TRUNCATE] database is locked

Mihon version

0.16.5-6776

Android version

Android 14

Device

Google Pixel 7 Pro

Other details

No response

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
  • I have written a short but informative title.
  • I have gone through the FAQ and troubleshooting guide.
  • I have updated the app to version 0.16.5.
  • I have updated all installed extensions.
  • I will fill out all of the requested information in this form.
@vetleledaal vetleledaal added the Bug Something isn't working label Jul 18, 2024
Animeboynz added a commit to Animeboynz/mihon that referenced this issue Jul 19, 2024
@Animeboynz
Fixes mihonapp#1029
63ebdd9
@Animeboynz Animeboynz mentioned this issue Jul 20, 2024
Merged
@AntsyLich AntsyLich added this to the v0.17.0 milestone Jul 24, 2024
AntsyLich pushed a commit that referenced this issue Jul 25, 2024
@Animeboynz @FooIbar
Format Category String on Subtitle Display (#1030)
88efde8 
* Fixes #1029

* Max Line Length Fix

* Update SettingsLibraryScreen.kt

No idea how this works.

Co-authored-by: Foolbar <118464521+Foolbar@users.noreply.github.com>

---------

Co-authored-by: Foolbar <118464521+Foolbar@users.noreply.github.com>
cuong-tran pushed a commit to komikku-app/komikku that referenced this issue Jul 26, 2024
@Animeboynz @cuong-tran
Format Category String on Subtitle Display (mihonapp/mihon#1030)
ee92333 
* Fixes mihonapp/mihon#1029

* Max Line Length Fix

* Update SettingsLibraryScreen.kt

No idea how this works.

Co-authored-by: Foolbar <118464521+Foolbar@users.noreply.github.com>

---------

Co-authored-by: Foolbar <118464521+Foolbar@users.noreply.github.com>
(cherry picked from commit 88efde8)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging a pull request may close this issue.

Format Category String on Subtitle Display Animeboynz/mihon
2 participants
@vetleledaal @AntsyLich