Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash screen won't show up after PR #1237 #1332

Closed
6 tasks done
cuong-tran opened this issue Oct 16, 2024 · 0 comments
Closed
6 tasks done

Crash screen won't show up after PR #1237 #1332

cuong-tran opened this issue Oct 16, 2024 · 0 comments
Labels
Bug Something isn't working

Comments

@cuong-tran
Copy link
Contributor

cuong-tran commented Oct 16, 2024 •
edited
Loading

Steps to reproduce

  1. Try create some crash situation, maybe throw some exceptions.

Expected behavior

  • CrashScreen should show
  • Crash event should still be pushed to Firebase
  • App should continue to work.

Actual behavior

  1. App keeps restarting (can see in log also), showing blank screen with/without dialog message something like "App keeps close, Wait/Close".
  2. CrashScreen won't show.
  3. Must manually close the app to be able to use it again.

Crash logs

API-34-Android-14_2024-10-17_085604.logcat.zip

Mihon version

latest dev build

Android version

Android 14

Device

AVD

Other details

This happens after PR #1237 adding option to opt-out of Firebase crashlytics/analytics.

But before that PR, I think the GlobalExceptionHandler trying to intercept exception in order to show CrashActivity and eventually didn't actually report any event to Firebase.

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
  • I have written a short but informative title.
  • I have gone through the FAQ and troubleshooting guide.
  • I have updated the app to version 0.16.5.
  • I have updated all installed extensions.
  • I will fill out all of the requested information in this form.
@cuong-tran cuong-tran added the Bug Something isn't working label Oct 16, 2024
@cuong-tran cuong-tran mentioned this issue Oct 17, 2024
Closed
cuong-tran pushed a commit to komikku-app/komikku that referenced this issue Oct 21, 2024
@AntsyLich @cuong-tran
Rework Firebase setup
48b326f 
Fixes mihonapp/mihon#1332
Closes mihonapp/mihon#1339

(cherry picked from commit 15e3f28)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix app keeps restarting & unable to run CrashActivity cuong-tran/mihon
1 participant
@cuong-tran