Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension install or update via shizuku applied to main user when Mihon installed in secondary user #493

Closed
6 tasks done
Redjard opened this issue Mar 8, 2024 · 0 comments
Labels
Bug Something isn't working

Comments

@Redjard
Copy link
Contributor

Redjard commented Mar 8, 2024

Steps to reproduce

  • Install Mihon in secondary user (I used island to create userID 10)
  • Set Install method to Shizuku in settings and give Mihon permissions
  • install an extension app
  • update an extension app

Expected behavior

installing an extension installs it for user 10 but not user 0
updating an extension only updates the extension

Actual behavior

installing an extension installs it for user 0 but not user 10 (where Mihon lives), Mihon doesn't see the extension until it is manually mirrored
updating an extension installs it for user 0 if not installed there. As app versions are global the extension is still updated for user 10

Crash logs

No response

Mihon version

0.16.4

Android version

Android 13 (lineageos 20)

Device

Sony Xperia 1 III (with lineageos custom rom)

Other details

This file seems to run
pm install-create --user current -r -i ${service.packageName} -S $size
using a root thread by shizuku. Is it possible that the --user current may be getting the user of the shizuku session, which is the main user 0?

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
  • I have written a short but informative title.
  • I have gone through the FAQ and troubleshooting guide.
  • I have updated the app to version 0.16.4.
  • I have updated all installed extensions.
  • I will fill out all of the requested information in this form.
@Redjard Redjard added the Bug Something isn't working label Mar 8, 2024
Redjard added a commit to Redjard/mihon that referenced this issue Mar 8, 2024
Fetch the current userid separately because shizuku always runs as the main user and would otherwise install and update for the main user
Redjard added a commit to Redjard/mihon that referenced this issue Mar 8, 2024
AntsyLich added a commit to kaiserbh/mihon that referenced this issue Mar 9, 2024
* Fix mihonapp#493

Fetch the current userid separately because shizuku always runs as the main user and would otherwise install and update for the main user

* Update app/src/main/java/eu/kanade/tachiyomi/extension/installer/ShizukuInstaller.kt

---------

Co-authored-by: AntsyLich <59261191+AntsyLich@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant