Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Insert chapter name] x.5 becomes Chapter 5 when displaying as chapter number #554

Closed
6 tasks done
Xori71 opened this issue Mar 21, 2024 · 4 comments
Closed
6 tasks done

[Insert chapter name] x.5 becomes Chapter 5 when displaying as chapter number #554

Xori71 opened this issue Mar 21, 2024 · 4 comments
Labels
Bug Something isn't working

Comments

@Xori71
Copy link

Xori71 commented Mar 21, 2024 •
edited
Loading

Steps to reproduce

  1. Find the One-Punch Man manga in a well-known source.
  2. Go towards the end and find the “Mag Version” 193.5 and 194.5 chapters.
  3. Display as chapter number.

Expected behavior

The chapter names should change to “Chapter” but the number remains the same.

Actual behavior

The chapter name changes to “Chapter” but the number turns from x.5 to 5.

Crash logs

No response

Mihon version

0.16.4

Android version

Android 14

Device

Redmi Note 9 Pro

Other details

screen-20240321-133026.mp4

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
  • I have written a short but informative title.
  • I have gone through the FAQ and troubleshooting guide.
  • I have updated the app to version 0.16.4.
  • I have updated all installed extensions.
  • I will fill out all of the requested information in this form.
@Xori71 Xori71 added the Bug Something isn't working label Mar 21, 2024
@MajorTanya
Copy link
Contributor

While we understand why you're naming a source, please remove the name from your issue.

@Xori71
Copy link
Author

Xori71 commented Mar 21, 2024

While we understand why you're naming a source, please remove the name from your issue.

Is this okay? Or should I remove any traces entirely?

@MajorTanya
Copy link
Contributor

While we understand why you're naming a source, please remove the name from your issue.

Is this okay? Or should I remove any traces entirely?

This is fine, thank you 👍

@Xori71
Copy link
Author

Xori71 commented Mar 21, 2024

While we understand why you're naming a source, please remove the name from your issue.

Is this okay? Or should I remove any traces entirely?

This is fine, thank you 👍

You’re welcome.

@Naputt1 Naputt1 mentioned this issue Jun 6, 2024
Closed
cuong-tran pushed a commit to komikku-app/komikku that referenced this issue Jun 10, 2024
@AntsyLich @cuong-tran
Fix chapter number parsing when number is after unwanted tag
73dcdd2 
Fixes mihonapp/mihon#554

Co-authored-by: Naputt1 <94742489+Naputt1@users.noreply.github.com>
(cherry picked from commit 6a80305)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix chapter number Naputt1/mihon
2 participants
@MajorTanya @Xori71