Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a button to select all scanlators #1109

Closed
wants to merge 2 commits into from

Conversation

mm12
Copy link
Contributor

@mm12 mm12 commented Aug 11, 2024

Resolves #943

image

A new "select all" button is added to the "exclude scanlators" dialogue. Pressing it clears all selected items then adds all available items.

Signed-off-by: Catting <5874051+mm12@users.noreply.github.com>
@AntsyLich
Copy link
Member

this feels overwhelming

@mm12
Copy link
Contributor Author

mm12 commented Aug 11, 2024

this feels overwhelming

It does feel squashed, yes. Perhaps a tri-state checkbox or something would work better? Or wording other than "select all"?

@BrutuZ
Copy link

BrutuZ commented Aug 11, 2024

Just throwing an idea there: Replace "Reset" with "Toggle All" instead?

Signed-off-by: Catting <5874051+mm12@users.noreply.github.com>
@AntsyLich AntsyLich closed this in 84b2164 Aug 11, 2024
@mm12 mm12 deleted the scanlator-select-all branch August 11, 2024 20:53
cuong-tran pushed a commit to komikku-app/komikku that referenced this pull request Aug 12, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an option to exclude every scanlator of a Manga
3 participants