Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an "open in browser" button to reader menu #1110

Merged
merged 2 commits into from
Aug 11, 2024

Conversation

mm12
Copy link
Contributor

@mm12 mm12 commented Aug 11, 2024

Resolves #1077 by adding an "open in browser" button to the menu

image

Clicking it opens the chapter in the default browser.

Signed-off-by: Catting <5874051+mm12@users.noreply.github.com>
Signed-off-by: Catting <5874051+mm12@users.noreply.github.com>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry apparently I didn't commit the changes I had before making the PR

@AntsyLich AntsyLich merged commit c5994e0 into mihonapp:main Aug 11, 2024
1 check passed
@mm12 mm12 deleted the add-chapter-open-in-browser branch August 11, 2024 22:11
cuong-tran pushed a commit to komikku-app/komikku that referenced this pull request Aug 12, 2024
* Add an "open in browser" button to reader menu

Signed-off-by: Catting <5874051+mm12@users.noreply.github.com>

* fixup! Add an "open in browser" button to reader menu

Signed-off-by: Catting <5874051+mm12@users.noreply.github.com>

---------

Signed-off-by: Catting <5874051+mm12@users.noreply.github.com>
(cherry picked from commit c5994e0)
cuong-tran pushed a commit to komikku-app/komikku that referenced this pull request Aug 12, 2024
* Add an "open in browser" button to reader menu

Signed-off-by: Catting <5874051+mm12@users.noreply.github.com>

* fixup! Add an "open in browser" button to reader menu

Signed-off-by: Catting <5874051+mm12@users.noreply.github.com>

---------

Signed-off-by: Catting <5874051+mm12@users.noreply.github.com>
(cherry picked from commit c5994e0)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to change Open in Webview to Open in Browser
2 participants