refactor: db changes for syncing. #113
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cing. So this should have been 0 on insert instead of the current time on insert. Essentially this issue arises: https://discord.com/channels/1099009852791083058/1099009853864812708/1190022356060614756 Signed-off-by: KaiserBh <kaiserbh@proton.me>
kaiserbh
added a commit
to kaiserbh/mihon
that referenced
this pull request
Feb 18, 2024
fix: sync marking chapter unread when we do library update before syncing. So this should have been 0 on insert instead of the current time on insert. Essentially this issue arises: https://discord.com/channels/1099009852791083058/1099009853864812708/1190022356060614756 Signed-off-by: KaiserBh <kaiserbh@proton.me> (cherry picked from commit e4a6565)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the lastModifiedAt default to 0 on insert, this way when syncing it doesn't mark chapter as unread.
For example:
Device A: has a manga with 79 chapter main device used for reading and more up to date.
Device B: haven't done any update library so it's stale, something like 78 chapter now when the user sync it will get the data from Device B as latest since on insert previously sets the current time.
Device A: Marks the chapter that was read as unread.
Well another approach is to sync before library update, but with this changes they don't have to sync before updating library.