Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect privacy settings in extension update notification #1156

Merged
merged 3 commits into from
Aug 25, 2024

Conversation

Animeboynz
Copy link
Contributor

@Animeboynz Animeboynz commented Aug 25, 2024

Removes the extension names from the notification when hide notification content is turned on.
Fixes #1022

Images

Before After
Before After

@AntsyLich
Copy link
Member

add to changelog

@Animeboynz
Copy link
Contributor Author

should done skip ci my bad

CHANGELOG.md Outdated Show resolved Hide resolved
@AntsyLich AntsyLich changed the title Hide extension names in notifications when hide content is on Respect privacy settings in extension update notification Aug 25, 2024
@AntsyLich AntsyLich merged commit 5dc6569 into mihonapp:main Aug 25, 2024
@Animeboynz Animeboynz deleted the ExtUpdatePrivacy branch August 25, 2024 13:49
cuong-tran pushed a commit to komikku-app/komikku that referenced this pull request Aug 26, 2024
…ihon#1156)

* Hide Extension Names in Update Notifications when Content is Hidden

* Moving `val` inside if

* [skip ci] Update CHANGELOG.md

(cherry picked from commit 5dc6569)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide extension name when Hide notification content is on
2 participants