Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bgm tracker showing empty due to no Chinese name #1184

Closed
wants to merge 1 commit into from
Closed

Fix bgm tracker showing empty due to no Chinese name #1184

wants to merge 1 commit into from

Conversation

NeKoOuO
Copy link
Contributor

@NeKoOuO NeKoOuO commented Sep 2, 2024 •
edited
Loading

Images

Before After
Screenshot_2024-09-02-12-57-57-546_app.komikku.beta-edit.jpg Screenshot_2024-09-02-13-22-09-339_app.mihon-edit.jpg

@AntsyLich
Copy link
Member

I'll keep this in hold until #1103 is merged

@NeKoOuO
Copy link
Contributor Author

NeKoOuO commented Sep 2, 2024 •
edited
Loading

I'll keep this in hold until #1103 is merged

I know, it's okay 😌

@NeKoOuO NeKoOuO marked this pull request as draft September 2, 2024 08:02
@AntsyLich
Copy link
Member

is name not summary?

@AntsyLich
Copy link
Member

Found some more stuff that needs fixing. i'll takeover this

@AntsyLich AntsyLich closed this Sep 2, 2024
@NeKoOuO NeKoOuO deleted the tracker branch September 3, 2024 02:50
@NeKoOuO
Copy link
Contributor Author

NeKoOuO commented Sep 3, 2024 •
edited
Loading

is name not summary?

What do you mean?
It seems that the previous developer used summary to display name and title to display nameCn

@NeKoOuO
Copy link
Contributor Author

NeKoOuO commented Sep 3, 2024

Found some more stuff that needs fixing. i'll takeover this

Yep, there's also a problem since the trackers have been create, the original site have changed by adding an NSFW option for entries, so the API has also changed. Now, if you want to track NSFW, the website will return empty results.
Screenshot_2024-09-03-11-01-18-519_com.brave.browser-edit.jpg

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NeKoOuO @AntsyLich