Retain remote last chapter read if it's higher than the local one for EnhancedTracker #1301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntsyLich
reviewed
Oct 10, 2024
Comment on lines
+40
to
+41
| val lastRead = max(remoteTrack.lastChapterRead, localLastRead.toDouble()) | ||
| val updatedTrack = remoteTrack.copy(lastChapterRead = lastRead) |
There was a problem hiding this comment.
We don't need to update the tracker in db given local one is less
AntsyLich
changed the title
cuong-tran
pushed a commit
to komikku-app/komikku
that referenced
this pull request
Oct 11, 2024
… EnhancedTracker (mihonapp/mihon#1301) (cherry picked from commit 44aab7a)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to #1298.
When adding an item to the library, with the #1298 fix, the track's last_read_chapter value set by
SyncChapterProgressWithTrackis always set to the local last read chapter.This fix uses the max between the local and remote last read chapter to set its new value.