Fix off by one error in SliderItem #1356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed formatting issue
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small error with how sliders are implemented that i noticed when trying to implement other changes. steps should be 1 less than the amount of steps you want if you are defining min and max, because steps takes in the amount of inner steps excluding the lowest and highest. as it is now if the slider passes the middle step, its starts skipping by 2 whenever decrementing.
(added a dummy slider so its easier to see, not in the code pushed)
example of slider now
https://github.com/user-attachments/assets/8d4231c0-411b-427f-a134-7a24278c1d8a
example of slider fixed
(https://github.com/user-attachments/assets/6e1a5ca8-c063-4c3e-b187-0f9972c77bb9)