fix: app crashes when delete a track if the entry is already removed … #1380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from tracker's service with option to "Also remove from <Tracker>"
AntsyLich
reviewed
Oct 26, 2024
| (tracker as DeletableTracker).delete(track) | ||
| try { | ||
| (tracker as DeletableTracker).delete(track) | ||
| } catch (e: Exception) { |
There was a problem hiding this comment.
this'll also fail on network errors
There was a problem hiding this comment.
I know, since the action is mainly removing track so just trying to catch any error on the side task of also removing entry from service.
Otherwise might need to implement:
- Check for network, if no network, no internet, failed to connect then won't allow user to remove track.
- If can connect to server then verify if the manga is exist then remove it from service, handle the return code to see if anything is wrong, maybe server got internal error which won't allow removing entry right now. With that we prevent user from remove the track.
And must implement that for all trackers. I would choose to prevent the app from crash first.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…from tracker's service
with option to "Also remove from <Tracker>"
close #1023