Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: null (visual) categories in Settings/Downloads/Exclude #1695

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cuong-tran
Copy link
Contributor

image

@MajorTanya
Copy link
Contributor

Would it be possible to use slightly more informative names for v and e?

@AntsyLich
Copy link
Member

We should be cleaning up the invalid IDs instead of doing this

@cuong-tran
Copy link
Contributor Author

cuong-tran commented Feb 3, 2025

We should be cleaning up the invalid IDs instead of doing this

they are not invalid, it's just that it's not ready loaded on first screen load so the subtitleProvider couldn't map anything.

Original caused after this PR: #1364

@cuong-tran
Copy link
Contributor Author

Would it be possible to use slightly more informative names for v and e?

I actually copied the default block from inside that method

@MajorTanya
Copy link
Contributor

Would it be possible to use slightly more informative names for v and e?

I actually copied the default block from inside that method

Would still be good if we had specific names in this location as opposed to the general purpose v, e in the block
That way it's actually readable in this state (right now I have no idea what v and e are)

@AntsyLich
Copy link
Member

Why is this an issue? Doesn't the items get replaced with actual name afterwards?

@MajorTanya
Copy link
Contributor

Why is this an issue? Doesn't the items get replaced with actual name afterwards?

Are you talking about my comment or why the categories get listed as "null"?

@AntsyLich
Copy link
Member

I'm talking about the PR

@cuong-tran
Copy link
Contributor Author

the entries are push to MultiSelectListPreferences when page is first created then mapped to categories' name; but at that moment categories catalog is still empty (due to PR #1364) hence all entries' name are null. After a bit the categories are loaded by subscribe but MultiSelectListPreferences does not recompose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants