Switch to seconds for DATE_MODIFIED of saved pages #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While most Android skins are seemingly able to handle the millisecond format, the documentation technically specifies seconds. This seems to be causing issues on Samsung devices using the Samsung Gallery app, which renders the millisecond timestamps as if they were second ones, causing the dates to be set at some point in the year 56189. This change should fix that issue on Samsung devices and have no real impact on the rest.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While most Android skins are seemingly able to handle the millisecond format, the documentation technically specifies seconds. This seems to be causing issues on Samsung devices using the Samsung Gallery app, which renders the millisecond timestamps as if they were second ones, causing the dates to be set at some point in the year 56189.
This change should fix that issue on Samsung devices and have no real impact on the rest.
Credit to @sirlag for figuring out the core issue :)