Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compose bom and fix renovate config for it #674

Merged
merged 1 commit into from
Apr 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion .github/renovate.json5
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,20 @@
"schedule": ["every friday"],
"labels": ["Dependencies"],
"packageRules": [
{
"groupName": "Compose BOM",
"matchPackageNames": [
"dev.chrisbanes.compose:compose-bom"
],
"ignoreUnstable": false
},
{
// Compiler plugins are tightly coupled to Kotlin version
"groupName": "Kotlin",
"matchPackagePrefixes": [
"androidx.compose.compiler",
"org.jetbrains.kotlin",
"org.jetbrains.kotlin.",
"org.jetbrains.kotlin:"
],
}
]
Expand Down
3 changes: 2 additions & 1 deletion gradle/compose.versions.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
[versions]
compiler = "1.5.11"
compose-bom = "2024.02.00-alpha02"
# 2024.04.00-alpha01 has several bugs with the new animateItem() modifier
compose-bom = "2024.03.00-alpha02"
accompanist = "0.35.0-alpha"

[libraries]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ fun AdaptiveSheet(
)
}
val internalOnDismissRequest = {
if (anchoredDraggableState.currentValue == 0) {
if (anchoredDraggableState.settledValue == 0) {
scope.launch { anchoredDraggableState.animateTo(1) }
}
}
Expand Down Expand Up @@ -192,7 +192,7 @@ fun AdaptiveSheet(

LaunchedEffect(anchoredDraggableState) {
scope.launch { anchoredDraggableState.animateTo(0) }
snapshotFlow { anchoredDraggableState.currentValue }
snapshotFlow { anchoredDraggableState.settledValue }
.drop(1)
.filter { it == 1 }
.collectLatest {
Expand Down
Loading