Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for mihonapp/mihon #420 #47

Merged
merged 9 commits into from
Mar 28, 2024
Merged

Add documentation for mihonapp/mihon #420 #47

merged 9 commits into from
Mar 28, 2024

Conversation

sirlag
Copy link
Contributor

@sirlag sirlag commented Mar 22, 2024

Updated FAQ section for the upcoming updates screen as per inclusion in #420

@sirlag sirlag mentioned this pull request Mar 22, 2024
Merged
@netlify Netlify
Copy link

netlify bot commented Mar 22, 2024 •
edited
Loading

✅ Deploy Preview for mihonapp ready!

Name Link
🔨 Latest commit 7c076fc
🔍 Latest deploy log https://app.netlify.com/sites/mihonapp/deploys/66023854549f5a0008604115
😎 Deploy Preview https://deploy-preview-47--mihonapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99
Accessibility: 100
Best Practices: 100
SEO: 91
PWA: 80
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

loocool2
loocool2 suggested changes Mar 23, 2024
View reviewed changes
Copy link
Contributor

@loocool2 loocool2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good but there are a few places that I think should be changed to be clearer.

website/src/docs/faq/upcoming.md Outdated Show resolved Hide resolved
website/src/docs/faq/upcoming.md Outdated Show resolved Hide resolved
@sirlag @loocool2
Apply suggestions from code review
51306f0 
Co-authored-by: loocool2 <36128021+loocool2@users.noreply.github.com>
@sirlag
Copy link
Contributor Author

sirlag commented Mar 23, 2024

Seems like good changes, thanks @loocool2

@Soitora
Copy link
Member

Soitora commented Mar 24, 2024

Maybe place the page at a subpage to Updates
/docs/faq/updates/upcoming rather than /docs/faq/upcoming

And then rename the page to just Upcoming

Rest looks fine to me, albeit maybe a bit too technically answered

@sirlag
Copy link
Contributor Author

sirlag commented Mar 24, 2024

@Soitora Only issue with that suggestion is we don't have a /updates currently. We could create one and put the info from the !smartupdates command from the discord into it.

@Soitora
Copy link
Member

Soitora commented Mar 24, 2024

@Soitora Only issue with that suggestion is we don't have a /updates currently. We could create one and put the info from the !smartupdates command from the discord into it.

I can look into adding it tomorrow or something, unless you wanna make a simple PR for it

Soitora added a commit that referenced this pull request Mar 25, 2024
@Soitora
Add Smart Updates page
c6f4e4b 
As suggested by @sirlag in #47

#47 (comment)
@AntsyLich AntsyLich merged commit b52c69b into mihonapp:main Mar 28, 2024
4 checks passed
Secozzi added a commit to Secozzi/aniyomi-website that referenced this pull request Jul 5, 2024
@Secozzi @Soitora
Add Smart Updates page
d221c32 
As suggested by @sirlag in mihonapp/website#47

mihonapp/website#47 (comment)

Co-authored-by: Soitora <10836780+Soitora@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loocool2 loocool2 loocool2 requested changes

@Soitora Soitora Soitora approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sirlag @Soitora @loocool2 @AntsyLich