Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UsbSerialPort Documentation Fixes #608

Merged
merged 1 commit into from
Nov 9, 2024
Merged

Conversation

HTRamsey
Copy link
Contributor

@HTRamsey HTRamsey commented Nov 8, 2024

  • Documented UnsupportedOperationException for getControlLines
  • Minor cleanup of setParameters when unsupported

@HTRamsey HTRamsey changed the title Fix Exception Handling & Documentation Fix Exception getControlLines Documentation & setParameters Cleanup Nov 8, 2024
@HTRamsey HTRamsey changed the title Fix Exception getControlLines Documentation & setParameters Cleanup Fix getControlLines Exception Documentation & setParameters Cleanup Nov 8, 2024
@HTRamsey HTRamsey closed this Nov 9, 2024
@HTRamsey HTRamsey reopened this Nov 9, 2024
@kai-morich
Copy link
Collaborator

kai-morich commented Nov 9, 2024

documentation improvements look good, but I intentionally did not add a default implementation to setParameter, to make it obvious that a device typically should implement it, and use UnsupportedOperationException(); only if there is really nothing to set.

@HTRamsey HTRamsey changed the title Fix getControlLines Exception Documentation & setParameters Cleanup UsbSerialPort Documentation Fixes Nov 9, 2024
@kai-morich kai-morich merged commit 2673407 into mik3y:master Nov 9, 2024
@HTRamsey HTRamsey deleted the dev-errors branch November 9, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants