Puppet improvements #225
Merged
Puppet improvements #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Either fix the missing {} around variable names, or drop quotes around
strings that only consist of a single variable.
Signed-off-by: Cyril Brulebois <cyril@debamax.com>
Signed-off-by: Cyril Brulebois <cyril@debamax.com>
Signed-off-by: Cyril Brulebois <cyril@debamax.com>
It shouldn't be needed when using apply.sh, but can help integrate this jenkins_debian_glue.pp file inside a bigger Puppet infrastructure. One would usually replace this with a call to stdlib's ensure_packages function, but at least dependencies are documented and don't need to be changed. Signed-off-by: Cyril Brulebois <cyril@debamax.com>
There's little point in specifying this attribute in each and every jenkins::plugin::install entry since all of them use it. So switch to using a default value for all entries. [ Best viewed with --patience ] Signed-off-by: Cyril Brulebois <cyril@debamax.com>
From the LTS changelog of 2.176.2 (2019-07-17):
Make sure detached plugins (plugins whose functionality used to be
part of Jenkins itself) are installed upon Jenkins startup when
needed as implied dependencies of other plugins which were already
present. This simplifies compatibility for specialized installation
scenarios not using the update center, such as when Jenkins is run
from a Docker image prepackaged with some plugins. (issue 57528)
More details in: https://issues.jenkins-ci.org/browse/JENKINS-57528
Signed-off-by: Cyril Brulebois <cyril@debamax.com>
|
If that's helpful, I can share logs from clean installations with:
|
|
Meh, really sorry that this took way longer than anticipated. :( But finally found time for it and once I fixed some further things with a) Debian/buster (gnupg not present) and b) git-client plugin dependency I could actually successfully test it. :) Thanks a bunch for the PR and fixes, highly appreciated! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Mika,
You'll find a couple of small puppet improvements, a heavy simplification (factorizing the
requireonPackage['jenkins']), and also a bugfix for Jenkins 2.176.2 regarding detached plugins.Unfortunately, even with those patches, I'm getting some other issues due to plugin dependencies, that I'll document separately, in an issue.
Thanks for considering,
Cyril, with his DEBAMAX hat.