Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add files to commit via hooks #39

Merged

Conversation

j-walker23
Copy link

This changes the isCleanRepository to pass if any changed files are staged

@tobiastom
Copy link

Is there anything I can help to merge this? Maybe add an additional option to make this feature opt in?

@j-walker23
Copy link
Author

Holy crap. This is literally so old i don't even remember doing this. Literally no part of this i remember! Man, getting old sucks.

@tobiastom
Copy link

@mikaelbr Any change this could be merged somehow?

@tobiastom
Copy link

Just for the record: my use case is the following: I keep a changelog which has an unreleased section at the top. To create a new release I now have to change the file and commit this as a separate commit. After that I can run mversion to release and tag it. I'd like to avoid the first commit.

@mikaelbr mikaelbr merged commit cf2d8d9 into mikaelbr:master Dec 4, 2018
@mikaelbr
Copy link
Owner

mikaelbr commented Dec 4, 2018

@tobiastom Merged now. You can check out the master branch (install thorugh npm i -g mikaelbr/mversion). If everything looks good, I'll publish a new version.

@tobiastom
Copy link

@mikaelbr Works perfectly for me. Thank you very much for this merge!

@tobiastom
Copy link

@mikaelbr Any chance we can get a new release of mversion? :)

@mikaelbr
Copy link
Owner

mikaelbr commented Feb 8, 2019

Sorry 😨

Fixed!

+ mversion@1.13.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants