Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please update terminal-notifier #183

Closed
sophistifunk opened this issue Jul 6, 2017 · 3 comments
Closed

Please update terminal-notifier #183

sophistifunk opened this issue Jul 6, 2017 · 3 comments

Comments

@sophistifunk
Copy link

It's got a serious memory leak
@mikaelbr
Copy link
Owner

mikaelbr commented Jul 6, 2017

I've been holding out (there is kind of a workaround in node-notifier for the memory leak) on updating due to some changes in the way icons are handled, and haven't found a good enough way to distribute ability to customize icons. The latest version is in master now if you want to test it out and check that it doesn't break any of your existing behaviour.

@charleskoehl
Copy link

Apparently the leak is fixed in v 1.7.2

@mikaelbr
Copy link
Owner

Done in 5.2.1

@alexilyaev alexilyaev mentioned this issue Jan 22, 2018
Closed
@rickhanlonii rickhanlonii mentioned this issue Feb 21, 2018
Closed
facebook-github-bot pushed a commit to facebook/react-native that referenced this issue Mar 5, 2018
@rickhanlonii @facebook-github-bot
Update node-notifier (has mem leak fix)
860fcd4 
Summary:
Noticed that we're on a version of node-notifier that has a leak mentioned [here](mikaelbr/node-notifier#183) and fixed in the newest version.

Automated tests

 [INTERNAL] [BUGFIX] [package.json] - Update node-notifier dependency
Closes #18033

Differential Revision: D7102637

Pulled By: hramos

fbshipit-source-id: 850f3d826c1d880a6281d95e4d5af68e9af89927
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sophistifunk @mikaelbr @charleskoehl