Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables the use of WindowsToaster when using WSL #260

Merged
merged 2 commits into from
Dec 4, 2018

Conversation

rmobis
Copy link
Contributor

@rmobis rmobis commented Nov 29, 2018

This uses the very simple is-wsl package to check when node is being run under WSL (Windows Subsystem for Linux) and instead of using Linux's NotifySend notifier (which doesn't work) uses WindowsToaster.

Without this change, notifications inside WSL don't popup on Windows.

@rmobis
Copy link
Contributor Author

rmobis commented Dec 2, 2018

Guys, anything that needs to be improved here?

@mikaelbr
Copy link
Owner

mikaelbr commented Dec 4, 2018

Oh. Thanks! Hadn't even considered this an issue. Thanks!

@mikaelbr mikaelbr merged commit 3050716 into mikaelbr:master Dec 4, 2018
@rmobis
Copy link
Contributor Author

rmobis commented Dec 5, 2018

I just noticed, we might have to update DECISION_FLOW.md to reflect these changes.

@jakeg
Copy link

jakeg commented Feb 2, 2019

Any idea when a new release will be rolled out with this change added? Very keen to start using it.

@rmobis
Copy link
Contributor Author

rmobis commented Feb 2, 2019

Been waiting for a while for a new release too. In the meantime, if node-notifier is a direct dependency of your project you may use my fork in your package.json like this:

"node-notifier": "github:rmobis/node-notifier"

Or, if you're using it through webpack-build-notifier, I've also made a fork of it simply to use my fork of node-notifier. You can also use it in your package.json like this:

"webpack-build-notifier": "github:rmobis/webpack-build-notifier"

@mikaelbr
Copy link
Owner

mikaelbr commented Feb 3, 2019

Hi! New version out now:

node-notifier@5.4.0

(also you could have used this current version by doing npm i mikaelbr/node-notifier without using a fork)

@rmobis
Copy link
Contributor Author

rmobis commented Feb 3, 2019

Thanks!

(You're right; I made the fork of webpack-build-notifier before this PR was merged and after that I completely forgot about it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants