-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #193 - windows actions + Upgrades SnoreToast to v0.7.0 #293
Conversation
yoavain
commented
Oct 28, 2019
- Updated SnoreToast to 0.7.0
- Support SnoreToast "-b" flag for action buttons
- Communicate with SnoreToast using unique named pipes
- Parse result from pipe into data object before calling the actionJackerDecorator
- Sanitizing data now changes "timedout" to "timeout"
- Sample file
- package.json script to run toaster with actions
- Sample gif for README
* Updated SnoreToast to 0.7.0
* Support SnoreToast "-b" flag for action buttons * Communicate with SnoreToast using unique named pipes * Parse result from pipe into data object before calling the actionJackerDecorator * Sanitizing data now changes "timedout" to "timeout" * Sample file
* package.json script to run toaster with actions * Sample gif for README
Issue 193 windows actions
* Sample gif for README
I saw the build is broken. Will have a look... |
* Revert test to work as before * Change toaster back to sync function, that uses callback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @yoavain ! I left a couple comments from glancing at the code, and I should have some time later tonight to pull it down and run it to make sure things look good. I'm gonna go ahead and approve, but I won't merge it yet. Ideally we'll get a review from @mikaelbr when he's got a few minutes :)
Co-Authored-By: Jordan Nielson <jnielson94@gmail.com>
Co-Authored-By: Jordan Nielson <jnielson94@gmail.com>
Co-Authored-By: Jordan Nielson <jnielson94@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this and the great work! It looks good to me. Could you also extend the documentation readme to include basic usage for this?
Is there any way we could align the action types with macOS? Or show an example which is cross OS friendly?
I will try and open another PR for the documentation. Regarding the cross OS: I was trying to support all these actions, and I might missed on keeping it cross-platform friendly. |