Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check-box to mark "done" on the tasks. #7

Open
apintocr opened this issue Aug 5, 2013 · 8 comments
Open

Check-box to mark "done" on the tasks. #7

apintocr opened this issue Aug 5, 2013 · 8 comments
Labels

Comments

@apintocr
Copy link
Contributor

apintocr commented Aug 5, 2013

Would be nice to add a check-box so we can mark the TODO Tasks as "done".
Feature could be extended to allow inline edit of the given task, directly on the results panel.

@mikaeljorhult
Copy link
Owner

As the comments are stored in the source itself I don't think that a checkbox would be he right choice. When clicking it the task would be removed from the file and therefore also removed from the list. A link deleting the comment would make more sense as it's not a toggle.

@apintocr
Copy link
Contributor Author

apintocr commented Aug 8, 2013

I was thinking about adding something Like [×] and checking it via regex.

Utitlity is because you can Mark it as Done to keep track of what you have
done. Every tasklist uses this philosofy.

When marked it just greys out and strikethrough.

@apintocr
Copy link
Contributor Author

apintocr commented Aug 8, 2013

Also, sometimes what you fixed isnt really fixed and you need to track back.

@mikaeljorhult
Copy link
Owner

Okay, that makes sense but I think most developers would expect it to remove it from the code as this is how it's done when doing it by hand.

A solution might be to add a check symbol (✓), to have the task marked as done and kept in source, and a times symbol (×) to have the task removed from source.

@clouddueling
Copy link

I love this idea if:
// TODO Create this feature.

became:

// [DONE] TODO Create this feature.

If this could just have a checkmark next to it I'd have nothing to complain about and a history of fixes in this document without reading through git commit history.

screen shot 2013-11-05 at 8 30 39 am

mikaeljorhult added a commit that referenced this issue Nov 12, 2013
@ghost
Copy link

ghost commented Nov 21, 2013

The checkbox will be very useful if it swap the "[x]" value in the comment (as the "[x]" is already working).

@mikaeljorhult
Copy link
Owner

That's the way I plan to implement it.

@mikaeljorhult
Copy link
Owner

mikaeljorhult commented Mar 30, 2017

I've been experimenting with this and I haven't found a nice and clean way to write to the files.

I would recommend just deleting the comment once a task is done as there's probably no reason to have todos in your code that has been completed.

Feel free to pull request this if you have ideas!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants