Format validator.rs #265
Closed
Format validator.rs #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Most (use vs full paths) was done using `clippy --fix`. * The unused methods and traits did look unused and have been removed. * The doc comments have been indented to a consistent level.
|
I don't like deleting large sections of code in PRs - it feels wrong somehow so apologies for that. On the other hand the lints on other PRs are failing and warning noise is not helpful. Happy to roll back the deletions (or abandon the PR) if you'd prefer. |
|
hey, sorry for that... I ended up fixing the errors before realizing now you had written a PR... |
|
No problem. Glad to see it's fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix the linting for the other PRs