Wait until frame stopped loading otherwise images are not loaded #3
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This html Abraham_Lincoln.html.txt includes (non-local) images, the printed pdf Abraham_Lincoln_1.0.40_wo_cache.pdf does not contain images.
This is the script I used:
When I ran the script again, the pdf contains images:
Abraham_Lincoln_1.0.40_w_cache.pdf
This means that if images are cached, the pdf contains images.
This PR lets pdfy wait until a frame stop loading.
Abraham_Lincoln_pr_wo_cache.pdf
The pdf contains images even when images are not cached.