feat(ripgrep): new setting project_root_fallback #104
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow disabling completion when project_root_marker is not found.
|
Fixes: #103 |
|
I think this looks great. I added a test and it seems to work locally. I'll try to figure out why the tests are not running in this PR later, and then merge this in. If you have any idea why that might be happening, I could use some ideas 🙂 |
|
This was just merged in a new PR here #112 Thanks a lot for the feature, and sorry it took a while to get it in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow disabling completion when project_root_marker is not found.
This gives the option for user's that want to disable ripgrep when using neovim in a spot where project_root_marker would go unfound and their cwd would result in poor preformance (like opening neovim in $HOME)
Couldn't get tests to run on my machine, so I would like some help in making sure everything correct 🙏