Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(output): Output as JSON for consumption with jq #6

Merged
merged 1 commit into from
Sep 25, 2018

Conversation

shousper
Copy link
Contributor

@shousper shousper commented Sep 21, 2018

Summary

I really want a CLI tool that outputs the whole JWT as JSON, yours seemed the easiest to modify, and it's also very easy to install ⭐️ .

I thought considered adding a --json argument for this output format but wondered first if maybe you'd just prefer this be the default? Happy with either, just really want a tool that outputs JSON for the whole payload so I can extract values with jq. 👌

Preflight checklist

  • Code formatted with rustfmt
  • Relevant tests added
  • Any new documentation added

@mike-engel
Copy link
Owner

Howdy @shousper thanks for the PR! I like this idea, but I think I'd like it to be behind a --json, -j flag, since the output now adds some helpful output for validity and any errors. If you could also add some tests that would be great. Thanks!

@shousper
Copy link
Contributor Author

@mike-engel Done mate, cheers! :)

@mike-engel mike-engel merged commit 37fde65 into mike-engel:master Sep 25, 2018
@mike-engel
Copy link
Owner

@shousper merged and released! If you have it installed with homebrew, you can update to the latest version now with brew update; brew upgrade mike-engel/jwt-cli/jwt-cli. If you're on linux or windows, binaries are available on the downloads page. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants