Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish as CommonJS module #100

Closed
wants to merge 1 commit into from
Closed

Conversation

slosd
Copy link
Contributor

@slosd slosd commented Aug 7, 2021

I experienced both these issues, which occur because of the distribution as an
ES module:

#98 #96

I'm working on a node project with several dependencies on typescript projects
(including ioredis), none of which publishes as ES module. Migrating the project
to ES modules (in compiler options) comes with quite a few inconveniences and
leads to a degradation of the developer experience with VS code. In my opinion
it isn't a reasonable option for us at the moment, so I'd love to see this
changed.

@mike-marcacci
Copy link
Owner

Thanks so much for this contribution @slosd! I ended up taking the strategy proposed in #114 of publishing both CJS and ESM. While that approach has its own complexities, I felt that it best balanced my goals here. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants