Readme - new args for the using() example #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the readme as it was made me think that senderId and recipientId were something specific to the redlock algorithm that I needed to know, instead they are just generic identifiers, so in a generic example I think it's better to use something generic like "foo" or "a" etc.
Update README.md - new params for example of using()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going trough the Readme, it made me think that
senderIdandrecipientIdwere something specific to the redlock paradigm that I needed to know, instead they are just generic identifiers for the names of the locks, since this is a generic example I think it's better to use something generic like "foo" or "bar".This is also in line with the next part of the readme, the "acquire" example which uses the string "a" which is clearly a generic identifier