Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecation warnings #62

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

BitBrit
Copy link

@BitBrit BitBrit commented Apr 12, 2019

@backspace
Copy link
Collaborator

This addon currently aims to support Ember versions all the way back to 1.13, so a direct replacement doesn’t work because some of these facilities don’t exist in older versions of Ember.

@bonroyage
Copy link

Just throwing out an idea because I'm also looking for ways to clear my application of as many deprecation warnings as possible, one of the other addons I use is ember-router-scroll. In this file they account for backward compatibility by using the gte method provided by ember-compatibility-helpers.

Between lines 22-30 they add listeners for the new router events and between lines 119-133 they extend the mixin again to add the legacy event handlers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants