Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't call new A #179

Open
jacobq opened this issue Sep 30, 2019 · 1 comment · May be fixed by #180
Open

Don't call new A #179

jacobq opened this issue Sep 30, 2019 · 1 comment · May be fixed by #180

Comments

@jacobq
Copy link
Contributor

jacobq commented Sep 30, 2019

This addon is causing the following error to be thrown when used in an Ember 3.13 app (and likely with earlier versions too):

Error: Assertion Failed: You cannot create an Ember Array with new A(), please update to calling A as a function: A()

The fix should be trivial (remove new).
See https://deprecations.emberjs.com/v3.x/#toc_array-new-array-wrapper

Here is the offending line:

return new A(comps && comps.size ? this.get('_childComponents').list : []);

jacobq added a commit to jacobq/ember-composability that referenced this issue Sep 30, 2019
@jacobq jacobq linked a pull request Sep 30, 2019 that will close this issue
@Gorzas
Copy link

Gorzas commented Nov 17, 2020

This is related with this problem I'm having with the library ember-cli-materialize, don't know how to use this changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants