Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes flakey local assertion #144

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ryanlabouve
Copy link

I kept running into the issue locally where the data.startTime and data.endTime would be exactly the same in unit test and cause the test suite to randomly fail.

Can we instead test for >=?

dummy tests 2018-04-16 20-41-54

@ryanlabouve
Copy link
Author

Specifically failing here:

test('measureRender returns a promise', function(assert) {

@ryanlabouve
Copy link
Author

Seems like we are getting an unrelated failure from Travis:

 [0417/015914.079769:FATAL:setuid_sandbox_host.cc(157)] The SUID sandbox helper binary was found, but is not configured correctly. Rather than run without sandboxing I'm aborting now. You need to make sure that /opt/google/chrome/chrome-sandbox is owned by root and has mode 4755.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant