Add random seed to formatters #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/rspec/rspec-core/blob/a99ff265c6c9d08650acbb34917aabcf1a60c1d4/lib/rspec/core/formatters/base_text_formatter.rb#L15 and https://github.com/rspec/rspec-core/blob/a99ff265c6c9d08650acbb34917aabcf1a60c1d4/lib/rspec/core/formatters/base_text_formatter.rb#L54-L57
|
Thanks for the contribution! |
|
@ApeChimp Could you release a new version with this change? I just debugged the internals of RSpec and this gem forever until I realized that this PR was simply not part of the 0.0.1 version I had installed. 😕 |
|
Sorry about that! Just published v1.0.0 which includes this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically just like the upstream:
https://github.com/rspec/rspec-core/blob/a99ff265c6c9d08650acbb34917aabcf1a60c1d4/lib/rspec/core/formatters/base_text_formatter.rb#L15
and
https://github.com/rspec/rspec-core/blob/a99ff265c6c9d08650acbb34917aabcf1a60c1d4/lib/rspec/core/formatters/base_text_formatter.rb#L54-L57
Without it really hard to debug dependency failures on teamcity