Removing use of user model in public property #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal here was to remove the use of the User model within the public properties. The bulk of this is taken from the initial PR work (#21 ) from @pjkellar but with some tweaks.
The tweaks are on the basis that, technically Megaphone and Laravel notifications could be attached to something other than a user modal (i.e. a Team). So the tweaks are to allow a $notifiableId to be passed into the component from the view, then only if that is not passed in, will it then simply fallback to the logged in user.
Put this in draft for now as I want to perform some more tests and update the documentation to reflect this change.
Fixes #20