Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] FFT convolver load during session #929

Closed
corrpel opened this issue Nov 5, 2019 · 12 comments
Closed

[Feature] FFT convolver load during session #929

corrpel opened this issue Nov 5, 2019 · 12 comments

Comments

@corrpel
Copy link

corrpel commented Nov 5, 2019

Hello,
It would be awesome to be able to load different impulse response file while audio is playing.
How i use FFT:
I add some reverb and modify the low frequency values to my likes.
But sometimes, let's say at 10 PM, i want to apply a different sound signature to reduce disconfort for my neighbords, so it would be nice to load a new sample via dbus for example, without needing to modify the config file and restart the application.

@mikebrady
Copy link
Owner

Thanks for the suggestion. I’ll have a look at it.

@mikebrady
Copy link
Owner

@corrpel , would you have any impulse response files you could share for experimentation, or could you point to any that are already available, please?

@corrpel
Copy link
Author

corrpel commented Nov 11, 2019 via email

@mikebrady
Copy link
Owner

Thanks. I’ve made some headway on it and I’d like to test it out a bit.

@corrpel
Copy link
Author

corrpel commented Nov 11, 2019

dirac_boom.zip
dirac is a linear impulse response
boom is a bit modified

@mikebrady
Copy link
Owner

I've just pushed 3.3.5d1 into the development branch with some new properties in the native D-Bus interface to enable you to control convolution. If you got a chance to try it out, I'd be interested to hear of your experiences.

@mikebrady
Copy link
Owner

Actually, wait, there's a compilation bug....

@mikebrady
Copy link
Owner

Compilation bugs fixed!

@corrpel
Copy link
Author

corrpel commented Nov 12, 2019

Nice!
Is working very well.
I've tested disable, enable, and load new file.
All working good!
Thank you!

@mikebrady
Copy link
Owner

Thanks. I’ll close this issue when the update is pushed to the master branch.

@PaulWieland
Copy link

PaulWieland commented Mar 29, 2021

Can either of you elaborate on how to use this feature?

I believe that I have the dsp/convolution_ir_file generated correctly but I would like to be able to toggle it on/off or between different filter files to hear the effect.

FYI - I'm using the docker image if that matters...

EDIT: I found the Sample DBUS commands file and was able to figure out what the Convolution properties were by searching the source code.

  • To turn off the filter: dbus-send --print-reply --system --dest=org.gnome.ShairportSync /org/gnome/ShairportSync org.freedesktop.DBus.Properties.Set string:org.gnome.ShairportSync string:Convolution variant:boolean:false
  • Turn it back on: variant:boolean:true

@github-actions
Copy link

This issue has been inactive for 60 days so will be closed 7 days from now. To prevent this, please remove the "stale" label or post a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants