Skip to content

Commit

Permalink
Removed script tags
Browse files Browse the repository at this point in the history
  • Loading branch information
mikebronner authored Mar 9, 2017
1 parent b87b0a8 commit 9e9df82
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions public/genealabs-laravel-mixpanel/js/mixpanel.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 comments on commit 9e9df82

@richardbenson
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks the blade view version btw

@mikebronner
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reporting ... can you elaborate what you mean by "blade view version"? Thanks :)

@richardbenson
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/GeneaLabs/laravel-mixpanel/blob/master/README.md#blade-template

Admittedly, a better solution is to have the blade template add the script tags so that this file is correct.

Incidentally, should it have the init in there too with someone else's token?

@mikebronner
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doh! creating issue for this now. Thanks!!

Please sign in to comment.